Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes environment variable export. #5016

Merged
merged 2 commits into from
Apr 20, 2018
Merged

Fixes environment variable export. #5016

merged 2 commits into from
Apr 20, 2018

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Apr 17, 2018

There was a trivial error while exporting the environment variables for the zones which I fixed in this PR.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2018
@mikesplain
Copy link
Contributor

mikesplain commented Apr 18, 2018

Good catch @Raffo! Thanks so much for the contribution!

/ok-to-test
/area documentation
/lgtm

@k8s-ci-robot k8s-ci-robot added area/documentation lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2018
@Raffo
Copy link
Contributor Author

Raffo commented Apr 20, 2018

/assign @KashifSaadat

@KashifSaadat
Copy link
Contributor

/approve

Thanks for the PR! :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, mikesplain, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit dc3f9e1 into kubernetes:master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants