Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IAM role for current versions of the kube-ingress-aws-controller #5014

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix IAM role for current versions of the kube-ingress-aws-controller #5014

merged 1 commit into from
Apr 19, 2018

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Apr 17, 2018

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2018
@szuecs szuecs mentioned this pull request Apr 17, 2018
Closed
mikkeloscar
mikkeloscar reviewed Apr 17, 2018
View reviewed changes
addons/kube-ingress-aws-controller/README.md Outdated
"autoscaling:DetachLoadBalancers",
"autoscaling:DetachLoadBalancerTargetGroups",
"autoscaling:AttachLoadBalancerTargetGroups",
"autoscaling:*",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use * here, you just need these permissions: https://github.com/zalando-incubator/kubernetes-on-aws/blob/dev/cluster/senza-definition.yaml#L266-L271

autoscaling:DescribeLoadBalancerTargetGroups is missing.

Copy link
Member Author

@szuecs szuecs Apr 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it was no missing, see the second deleted line (red line 92)

@szuecs
Copy link
Member Author

szuecs commented Apr 18, 2018

@mikkeloscar I found it, it was missing in the second policy shown.

@mikesplain
Copy link
Contributor

Thanks so much @szuecs. Mind squashing this into a single commit since it's only a small change?

/ok-to-test
/area documentation
/assign

@k8s-ci-robot k8s-ci-robot added area/documentation and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2018
@szuecs szuecs force-pushed the fix/kube-ingress-aws-controller branch from f43a6ca to f886296 Compare April 18, 2018 13:10
@szuecs
Copy link
Member Author

szuecs commented Apr 18, 2018

@mikesplain done

@mikesplain
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2018
@szuecs
Copy link
Member Author

szuecs commented Apr 18, 2018

/assign @gambol99

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, mikesplain, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit c353d49 into kubernetes:master Apr 19, 2018
@szuecs szuecs deleted the fix/kube-ingress-aws-controller branch April 20, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkeloscar mikkeloscar mikkeloscar left review comments

@mikesplain mikesplain mikesplain approved these changes

Assignees

@chrislovecnm chrislovecnm

@mikesplain mikesplain

@gambol99 gambol99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@szuecs @mikesplain @chrislovecnm @k8s-ci-robot @mikkeloscar @gambol99