Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #4985

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Fix typo #4985

merged 1 commit into from
Jun 8, 2018

Conversation

xianlubird
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2018
@justinsb
Copy link
Member

So unfortunately this is code is generated. The original repo looks to be https://github.com/Birdrock/brodocs/blob/master/README.md

We could just delete the FAQ here - it isn't relevant to kops. cc @pwittrock

chrislovecnm
chrislovecnm reviewed May 12, 2018
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question

docs/apireference/build/README.md
A: This project was born out of a collaboration with my brother to create a suitable docs app for his purposes. It was a fun name for the the two of us to use as actual brothers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we changed white space here.

@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2018
@xianlubird
Copy link
Contributor Author

/retest

@justinsb justinsb added this to the 1.11 milestone Jun 2, 2018
@justinsb
Copy link
Member

justinsb commented Jun 8, 2018

So I'm just going to merge this - it should keep our spell checker happy.

Thanks @xianlubird

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, xianlubird

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2018
@justinsb
Copy link
Member

justinsb commented Jun 8, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 06224f2 into kubernetes:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm left review comments

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@xianlubird @justinsb @chrislovecnm @k8s-ci-robot