Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some typo fix #4937

Merged
merged 6 commits into from
Jun 4, 2018
Merged

some typo fix #4937

merged 6 commits into from
Jun 4, 2018

Conversation

liwjGhostcloud
Copy link
Contributor

there are some typo fix

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2018
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Apr 8, 2018

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2018
mikesplain
mikesplain suggested changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liwjGhostcloud Thanks for the contributions! Do you mind making a few adjustments so we can have the same changes on each version of the API?

You'll also need to follow the directions here to regenerate the apireference docs: https://github.com/kubernetes/kops/tree/master/docs/apireference

Thanks so much!

pkg/apis/kops/cluster.go
@@ -384,7 +384,7 @@ type ClusterSubnetSpec struct {
Egress string `json:"egress,omitempty"`
// Type define which one if the internal types (public, utility, private) the network is
Type SubnetType `json:"type,omitempty"`
// PublicIP to attatch to NatGateway
// PublicIP to attach to NatGateway
PublicIP string `json:"publicIP,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finds! Can you add these to the other versions of this file:
https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/v1alpha1/cluster.go
https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/v1alpha2/cluster.go

This helps keeping the docs for the different versions the same!

pkg/apis/kops/v1alpha1/instancegroup.go
@@ -89,7 +89,7 @@ type InstanceGroupSpec struct {
Kubelet *KubeletConfigSpec `json:"kubelet,omitempty"`
// Taints indicates the kubernetes taints for nodes in this group
Taints []string `json:"taints,omitempty"`
// AdditionalUserData is any aditional user-data to be passed to the host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check to see if this mistake also exists on:
https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/v1alpha2/instancegroup.go
https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/instancegroup.go

@mikesplain
Copy link
Contributor

/assign

@chrislovecnm
Copy link
Contributor

/lgtm cancel

@mikesplain I think you had some comments, and I removed the lgtm so they can be addressed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@liwjGhostcloud
Copy link
Contributor Author

when i exec apiserver-boot build docs --disable-delegated-auth=false --output-dir docs/apireference --server kops-server ,they were told me
cp: cannot create symbolic link '/build/node_modules/.bin/marked': Operation not supported cp: cannot create symbolic link '/build/node_modules/.bin/mime': Operation not supported cp: cannot create symbolic link '/build/node_modules/.bin/static': Operation not supported
@mikesplain

@chrislovecnm
Copy link
Contributor

chrislovecnm commented May 12, 2018 •
edited
Loading

@liwjGhostcloud we broke the docs API docs generator when we moved to dep. If you could help with that, it would be amazing!

@justinsb justinsb added this to the 1.10 milestone Jun 2, 2018
@justinsb
Copy link
Member

justinsb commented Jun 4, 2018

Going to merge and fix-up any api docs problems. Thanks for the fixes @liwjGhostcloud

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, liwjGhostcloud, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit be94337 into kubernetes:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain requested changes

Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

@rdrgmnzs rdrgmnzs

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
6 participants
@liwjGhostcloud @rdrgmnzs @mikesplain @chrislovecnm @justinsb @k8s-ci-robot