lifecycle tests: check no legacy tags on shared resources #4797
Conversation
k8s-ci-robot
added
approved
|
As we discussed @chrislovecnm |
justinsb
force-pushed
the
check_no_legacy_tags_on_shared
branch
from
2b56daf to
51cc74c
Compare
| @@ -217,6 +219,9 @@ func runLifecycleTest(h *testutils.IntegrationTestHarness, o *LifecycleTestOptio | |||
| if ownership != expect { | |||
| t.Errorf("unexpected kubernetes.io/cluster/ tag on %q: actual=%q expected=%q", id, ownership, expect) | |||
| } | |||
| if legacy != "" { | |||
| t.Errorf("added (legacy) KubernetesCluster tag on %q, but it is shared", id) | |||
There was a problem hiding this comment.
Well, shouldn't we do this on route tables?
There was a problem hiding this comment.
Can you say why you think so?
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.