-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert registry to k8s.gcr.io #4137
Conversation
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Hmmm ... looks like the rename to k8s.gcr.io was reverted @thockin ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this one is free of pushes
this one seems ok to proceed. |
@thockin PR needs rebase |
PTAL |
@thockin PR needs rebase |
Rebased. PTAL |
Rebased and pushed. This is the last such PR.. |
/lgtm Thanks for the perseverance @thockin ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR was auto-generated. Please apply human expertise to review for correctness.
Followup to kubernetes/kubernetes#54174 and kubernetes/kubernetes#57824
xref kubernetes/release#281