Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert registry to k8s.gcr.io #4137

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

thockin
Copy link
Member

@thockin thockin commented Dec 22, 2017

This PR was auto-generated. Please apply human expertise to review for correctness.

Followup to kubernetes/kubernetes#54174 and kubernetes/kubernetes#57824

xref kubernetes/release#281

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2017
@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 27, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@justinsb
Copy link
Member

justinsb commented Jan 5, 2018

/retest

@justinsb
Copy link
Member

justinsb commented Jan 5, 2018

Hmmm ... looks like the rename to k8s.gcr.io was reverted @thockin ?

Copy link

@dekkagaijin dekkagaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one is free of pushes

@thockin
Copy link
Member Author

thockin commented Jan 17, 2018

this one seems ok to proceed.

@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @justinsb @thockin

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2018
@k8s-github-robot
Copy link

@thockin PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2018
@thockin
Copy link
Member Author

thockin commented Feb 2, 2018

PTAL

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2018
@k8s-github-robot
Copy link

@thockin PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2018
@thockin
Copy link
Member Author

thockin commented Feb 8, 2018

Rebased. PTAL

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2018
@thockin
Copy link
Member Author

thockin commented Feb 14, 2018

Rebased and pushed. This is the last such PR..

@justinsb
Copy link
Member

/lgtm

Thanks for the perseverance @thockin !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4b8db1e into kubernetes:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants