Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault when updating non-existent object #3980

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Fix segfault when updating non-existent object #3980

merged 1 commit into from
Dec 1, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Dec 1, 2017

Fix #3935

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2017
@chrislovecnm
Copy link
Contributor

@justinsb 1.9?

@justinsb justinsb added this to the 1.8.0 milestone Dec 1, 2017
@chrislovecnm
Copy link
Contributor

chrislovecnm commented Dec 1, 2017 •
edited
Loading

You gotta be using k8s 1.9 api machinery

cmd/kops/replace.go:131: undefined: "k8s.io/kops/vendor/k8s.io/apimachinery/pkg/api/errors".IsNotExist
cmd/kops/replace.go:160: undefined: "k8s.io/kops/vendor/k8s.io/apimachinery/pkg/api/errors".IsNotExist

Cause this is not building :)

@justinsb justinsb force-pushed the fix_3935 branch 2 times, most recently from 591865c to 1993d37 Compare December 1, 2017 07:56
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a7cdbd4 into kubernetes:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @chrislovecnm @k8s-ci-robot @k8s-github-robot