Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IAM Container Registry permissions by default when creating a cluster (#3760). #3761

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Enable IAM Container Registry permissions by default when creating a cluster (#3760). #3761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/kops/create_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,8 +919,10 @@ func RunCreateCluster(f *util.Factory, out io.Writer, c *CreateClusterOptions) e
}
}

// Use Strict IAM policy and allow AWS ECR by default when creating a new cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this to defaults.go? I want to start pulling business logic out of the cmd, so that building kops server will be easier.

cluster.Spec.IAM = &api.IAMSpec{
Legacy: false,
AllowContainerRegistry: true,
Legacy: false,
}

sshPublicKeys := make(map[string][]byte)
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/complex/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
name: a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha/expected-v1alpha1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ spec:
zone: us-test-1c
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesVersion: v1.6.0-alpha.3
masterPublicName: api.ha.example.com
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ spec:
name: c
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha_encrypt/expected-v1alpha1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ spec:
zone: us-test-1c
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesVersion: v1.6.0-alpha.3
masterPublicName: api.ha.example.com
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha_encrypt/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ spec:
name: c
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha_gce/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ spec:
name: c
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ha_shared_zones/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ spec:
name: a-3
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/minimal/expected-v1alpha1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ spec:
zone: us-test-1a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesVersion: v1.4.8
masterPublicName: api.minimal.example.com
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/minimal/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
name: a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ngwspecified/expected-v1alpha1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ spec:
zone: us-test-1a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesVersion: v1.4.8
masterPublicName: api.private.example.com
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/ngwspecified/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ spec:
name: a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/overrides/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
name: a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/private/expected-v1alpha1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ spec:
zone: us-test-1a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesVersion: v1.4.8
masterPublicName: api.private.example.com
Expand Down
1 change: 1 addition & 0 deletions tests/integration/create_cluster/private/expected-v1alpha2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ spec:
name: a
name: events
iam:
allowContainerRegistry: true
legacy: false
kubernetesApiAccess:
- 0.0.0.0/0
Expand Down