kops get ... should exit with non-zero if the resource don't exist
#3610
Conversation
Without this change, `kops get --name non-existing-cluster` will exit with a status of `0`, which makes it difficult to check if a cluster (and other resources) exist in a shell script.
|
Hi @erickt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
needs-ok-to-test
|
Yup this is a bug ... I do not think I will claim it ... but happy you fixed it :) I think we have an issue open for this, if I remember. |
| @@ -125,8 +125,7 @@ func RunGet(context Factory, out io.Writer, options *GetOptions) error { | |||
| } | |||
|
|
|||
| if cluster == nil { | |||
| fmt.Fprintf(os.Stderr, "No cluster found\n") | |||
| return nil | |||
| return fmt.Errorf("No cluster found") | |||
There was a problem hiding this comment.
We can do another PR, but I think we should be printing out the name, if we have one
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Without this change,
kops get --name non-existing-clusterwill exit with a status of0, which makes it difficult to check if a cluster (and other resources) exist in a shell script.cc @chrislovecnm, who I think originally wrote this code.