Use IsKubernetesGTE helper instead of reparsing semver #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
force-pushed
the
use_iskubernetesgte_helper
branch
from
9af2116 to
6997821
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
chrislovecnm
approved these changes
Sep 30, 2017
k8s-github-robot
added
the
approved
|
/retest |
justinsb
force-pushed
the
use_iskubernetesgte_helper
branch
from
6997821 to
7ebec76
Compare
k8s-ci-robot
added
size/M
|
A trivial change that became bigger mostly because of gofmt :-( |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @chrislovecnm @justinsb |
k8s-github-robot
removed
the
lgtm
justinsb
force-pushed
the
use_iskubernetesgte_helper
branch
from
7ebec76 to
58d8f16
Compare
justinsb
force-pushed
the
use_iskubernetesgte_helper
branch
from
58d8f16 to
df93d82
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.