Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs updates to clarify and fix typos in rolling-update cmd. #3452

Closed
wants to merge 6 commits into from
Closed

Docs updates to clarify and fix typos in rolling-update cmd. #3452

wants to merge 6 commits into from

Conversation

jlaswell
Copy link
Contributor

Helps with #3441; tried to keep the same voicing, but feel free to revert/update as desired of course.

justinsb and others added 2 commits September 25, 2017 09:41
@justinsb
Fix integration test
8c3d4c5 
PR crossed with others, I believe.
@jlaswell
docs updates to clarify and fix typos
68fcb5b 
Helps with kubernetes#3441.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 25, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @jlaswell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: chrislovecnm

Assign the PR to them by writing /assign @chrislovecnm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jlaswell
Copy link
Contributor Author

Happy to make the appropriate changes to get CI passing w/ a little insight into where I should start.

Kubernetes Submit Queue and others added 2 commits September 25, 2017 11:11
Merge pull request kubernetes#3451 from justinsb/fix_integration_test
aa72c12 
Automatic merge from submit-queue. .

Fix integration test
@justinsb
Tag 1.8.0-alpha.1
991cd8c
@chrislovecnm
Copy link
Contributor

@jlaswell we had another PR that came in that broke ci ... can you rebase and see if that helps?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2017
@jlaswell
Copy link
Contributor Author

Trying to re-trigger the cncf-cla label.

/joke

@chrislovecnm
Copy link
Contributor

/joke

bot listens to members :) and people with a CLA :(

@chrislovecnm
Copy link
Contributor

Random comment about CLA ... bot??

@jlaswell you may want to reach out to the email address. Good news is that you only have to jump through this once.

@jlaswell
Copy link
Contributor Author

I've been recommended to reopen a new PR to see if that'll solve the issue; thanks for your patience.

@jlaswell jlaswell closed this Sep 26, 2017
@jlaswell jlaswell deleted the update-rolling-update-cli-docs branch September 26, 2017 23:49
@jlaswell jlaswell mentioned this pull request Sep 26, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Sep 27, 2017
Merge pull request #3458 from jlaswell/update-rolling-update-cli-docs
dce1186 
Automatic merge from submit-queue.

Doc updates to clarify and fix typos in rolling-update cmd.

Helps with #3441. (Previous #3452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlaswell @k8s-ci-robot @k8s-github-robot @chrislovecnm @justinsb