Support for deleting tokens & keypairs #3359
Conversation
This now allows for deleting all secrets, which means we can have a procedure for rotating all keys.
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
the
approved
| @@ -55,6 +55,17 @@ func (c *VFSSecretStore) FindSecret(id string) (*fi.Secret, error) { | |||
| return s, nil | |||
| } | |||
|
|
|||
| func (c *VFSSecretStore) DeleteSecret(item *fi.KeystoreItem) error { | |||
There was a problem hiding this comment.
Is this generated? If not comments please ;)
upup/pkg/fi/vfs_castore.go
Outdated
| } | ||
| p := c.buildCertificatePath(item.Name, version) | ||
| if err := p.Remove(); err != nil { | ||
| return err |
There was a problem hiding this comment.
We use fmt when we are adding information to the error. Kinda marginal here, but I'll add it...
We need fmt.Errorf when we're returning a third party error we can't control. But if we wrap all our errors we end up with:
cannot do X: failed to do X: unable to X: error while doing X: <real error>
k8s-github-robot
removed
the
approved
|
Addressed comments - PTAL @chrislovecnm |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This now allows for deleting all secrets, which means we can have a
procedure for rotating all keys.