Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Docker build environments from creating root-owned artifacts #3354

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Prevent Docker build environments from creating root-owned artifacts #3354

merged 1 commit into from
Sep 10, 2017

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 8, 2017

The binaries in .build/artifacts are built in Docker containers and are owned by the root user.

I've created HOST_UID and HOST_GID variables in the Makefile that are passed in to the Docker build containers so that artifacts can be chowned to the proper user and group IDs.

Previously, it was impossible to make clean or rm -rf .build without root privileges.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2017
@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017

/test pull-kops-e2e-kubernetes-aws

@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017 via email

@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017

/test pull-kops-e2e-kubernetes-aws

@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017 via email

@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@alrs
Copy link
Contributor Author

alrs commented Sep 8, 2017

/test pull-kops-e2e-kubernetes-aws

@alrs
Copy link
Contributor Author

alrs commented Sep 9, 2017

/approve
/assign justinsb

chrislovecnm
chrislovecnm approved these changes Sep 10, 2017
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alrs, chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@chrislovecnm
Copy link
Contributor

All the polish you add is seriously appreciated!!!!!

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cbc6828 into kubernetes:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alrs @chrislovecnm @k8s-github-robot @justinsb @k8s-ci-robot