-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS Controller Limitation #3330
DNS Controller Limitation #3330
Conversation
@KashifSaadat .. can i have a review please :-) |
589e6e0
to
c52456b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test pull-kops-e2e-kubernetes-aws |
/retest |
1 similar comment
/retest |
grumble grumble testing ... /retest
|
@gambol99 PR needs rebase |
/lgtm Nice change, but needs a rebase it looks like. I believe our tests are (finally) happy again :-) |
/retest |
@gambol99 probably need a rebase on this. E2E seems to be running tonight |
@gambol99 can we get a rebase? |
The current implementation does not place any limitation on the dns annontation which the dns-controller can consume. In a multi-tenented environment was have to ensure certain safe guards are met, so users can't byt accident or intentionally alter our internal dns. Note; the current behaviour has not been changed; - added the --watch-namespace option to the dns controller and WatchNamespace to the spec - cleaned up area of the code where possible or related - fixed an vetting issues that i came across on the journey - renamed the dns-controller watcher files
c52456b
to
b647956
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. . |
The current implementation does not place any limitation on the dns annontation which the dns-controller can consume. In a multi-tenented environment we have to ensure certain safe guards are met, so users can't by accident or intentionally alter our internal dns. Note; the current behaviour has not been changed;