-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubelet Readonly Port #3303
Kubelet Readonly Port #3303
Conversation
The current implementaton does not permit the user to specify the kubelet read-only port (which unset defaults to 10255). Note security reasons we need this port switched off i.e. 0. This PR retains the default behaviour but adds the readOnlyPort as an options for those whom need to override. podInfraContainerImage: gcr.io/google_containers/pause-amd64:3.0 podManifestPath: /etc/kubernetes/manifests + readOnlyPort: 0 registerSchedulable: false requireKubeconfig: true
/assign @chrislovecnm |
a little bit of discussion here kubernetes/kubernetes#12968 on it ... but essentially we don't want pods to be able to iterate our nodes and discover information on whats running, settings, environment variables etc etc |
Is heapster using this port at all? |
hi @chrislovecnm ... yes, heapster use's this endpoint to grab metrics .. |
LGTM |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
The current implementation does not permit the user to specify the kubelet read-only port (which unset defaults to 10255). For security reasons we need this port switched off i.e. 0. This PR retains the default behavior but adds the readOnlyPort as an option for those whom need to override.
And tested on the box