Additional Kubelet Options #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @justinsb |
chrislovecnm
suggested changes
Aug 28, 2017
pkg/apis/kops/componentconfig.go
Outdated
| @@ -142,6 +142,10 @@ type KubeletConfigSpec struct { | |||
| SystemReservedCgroup string `json:"systemReservedCgroup,omitempty" flag:"system-reserved-cgroup"` | |||
| // Enforce Allocatable across pods whenever the overall usage across all pods exceeds Allocatable. | |||
| EnforceNodeAllocatable string `json:"enforceNodeAllocatable,omitempty" flag:"enforce-node-allocatable"` | |||
| // RuntimeRequesTimeout is timeout for runtime requests on - pull, logs, exec and attach | |||
| RuntimeRequesTimeout *metav1.Duration `json:"RuntimeRequestTimeout,omitempty" flag:"runtime-request-timeout"` | |||
There was a problem hiding this comment.
Lower case on Runtime JASON value please
There was a problem hiding this comment.
good spot! ... a copy and paste error .. i'll fix it now :-)
gambol99
force-pushed
the
kubelet_options
branch
from
30b88ab to
8245d3c
Compare
|
hi @chrislovecnm its been available since >= 1.3 |
pkg/apis/kops/componentconfig.go
Outdated
| @@ -142,6 +142,10 @@ type KubeletConfigSpec struct { | |||
| SystemReservedCgroup string `json:"systemReservedCgroup,omitempty" flag:"system-reserved-cgroup"` | |||
| // Enforce Allocatable across pods whenever the overall usage across all pods exceeds Allocatable. | |||
| EnforceNodeAllocatable string `json:"enforceNodeAllocatable,omitempty" flag:"enforce-node-allocatable"` | |||
| // RuntimeRequesTimeout is timeout for runtime requests on - pull, logs, exec and attach | |||
| RuntimeRequesTimeout *metav1.Duration `json:"runtimeRequestTimeout,omitempty" flag:"runtime-request-timeout"` | |||
There was a problem hiding this comment.
Key correction: RuntimeRequestTimeout (missing a t).
| @@ -142,6 +142,10 @@ type KubeletConfigSpec struct { | |||
| SystemReservedCgroup string `json:"systemReservedCgroup,omitempty" flag:"system-reserved-cgroup"` | |||
| // Enforce Allocatable across pods whenever the overall usage across all pods exceeds Allocatable. | |||
| EnforceNodeAllocatable string `json:"enforceNodeAllocatable,omitempty" flag:"enforce-node-allocatable"` | |||
| // RuntimeRequesTimeout is timeout for runtime requests on - pull, logs, exec and attach | |||
| RuntimeRequesTimeout *metav1.Duration `json:"runtimeRequestTimeout,omitempty" flag:"runtime-request-timeout"` | |||
There was a problem hiding this comment.
Same here: RuntimeRequestTimeout
| @@ -142,6 +142,10 @@ type KubeletConfigSpec struct { | |||
| SystemReservedCgroup string `json:"systemReservedCgroup,omitempty" flag:"system-reserved-cgroup"` | |||
| // Enforce Allocatable across pods whenever the overall usage across all pods exceeds Allocatable. | |||
| EnforceNodeAllocatable string `json:"enforceNodeAllocatable,omitempty" flag:"enforce-node-allocatable"` | |||
| // RuntimeRequesTimeout is timeout for runtime requests on - pull, logs, exec and attach | |||
| RuntimeRequesTimeout *metav1.Duration `json:"runtimeRequestTimeout,omitempty" flag:"runtime-request-timeout"` | |||
There was a problem hiding this comment.
Same here: RuntimeRequestTimeout
|
Small comments to address, otherwise looks good. |
In related to issue kubernetes#3265
gambol99
force-pushed
the
kubelet_options
branch
from
8245d3c to
bf5e154
Compare
|
hi @chrislovecnm ... should we add a check on this? ... i can't see similar checks of this type (albeit that's not a good reason) ... Do we support pre < 1.3 though? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add additional options to the kubelet spec allowing users to set the --runtime-request-timeout and -volume-stats-agg-period
In related to issue #3265