Changes on CoreOS related documentation. #3205

tigerlinux · 2017-08-15T16:01:31Z

Changed "experimental" to "production-ready" status on CoreOS
images.
Added a complete tutorial/exercise using a multi-master setup
with CoreOS

k8s-ci-robot · 2017-08-15T16:01:33Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2017-08-15T16:01:39Z

Hi @tigerlinux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tigerlinux · 2017-08-15T16:20:18Z

Hi,
Document signed !. Please check at your side !.
Thanks in advance,
RRMP.-

aledbf · 2017-08-15T16:31:50Z

docs/examples/coreos-kops-tests-multimaster.md

+--master-zones=us-east-1a,us-east-1b,us-east-1c \
+--zones=us-east-1a,us-east-1b,us-east-1c \
+--node-count=2 \
+${NAME}


You can use the flag --image in one please and avoid using kops edit

Done. Changed all related stuff and explained the ways to use --image (with either the name of the ami)

justinsb · 2017-08-15T17:24:31Z

Looks great - thanks @tigerlinux .

I did have a few suggestions, but I really like the idea of having more "hands on" documentation.

Want to go through the suggestions and see if you agree with them?

/ok-to-test

justinsb · 2017-08-15T17:09:41Z

docs/images.md


-> Note: SSH username will be `core`
+As part of our documentation, you will find a practical exercise using CoreOS with KOPS. See the file "coreos-kops-tests-multimaster.md" in the "examples" directory. This exercise covers not only using kops with CoreOS, but also a practical view of KOPS with a multi-master kubernetes setup.


You can make this a link, I think the syntax is [practical exercise using CoreOS with kops](examples/coreos-kops-tests-multimaster.md)

justinsb · 2017-08-15T17:11:42Z

docs/examples/coreos-kops-tests-multimaster.md

+
+- AWS cli fully configured (aws account already with proper permissions/roles needed for kops). Depending on your distro, you can setup directly from packages, or if you want the most updated version, use "pip" and installed by issuing a "pip install awscli" command. Your choice !.
+- Local ssh key ready on ~/.ssh/id_rsa / id_rsa.pub. You can generate it using "ssh-keygen" command: `ssh-keygen -t rsa -f ~/.ssh/id_rsa -P ""`
+- Region set to us-east-1 (az's: us-east-1a, us-east-1b, us-east-1c, us-east-1d and us-east-1e). For this exercise we deployed our cluster on US-EAST-1. If you want to use another region, feel free to change it. Just ensure to have at least 3 availability zones.


Instead of "Just ensure to have at least 3 availability zones" how about "It is recommended to pick a region with at least 3 availability zones, for true high-availability".

Some regions only have 2 AZs; we support multi master in those regions, but it isn't as HA.

Done !. Explained and included some links from AWS global infra.

justinsb · 2017-08-15T17:13:58Z

docs/examples/coreos-kops-tests-multimaster.md

+```bash
+export AWS_ACCESS_KEY_ID=`grep aws_access_key_id ~/.aws/credentials|awk '{print $3}'`
+export AWS_SECRET_ACCESS_KEY=`grep aws_secret_access_key ~/.aws/credentials|awk '{print $3}'`
+echo "$AWS_ACCESS_KEY_ID $AWS_SECRET_ACCESS_KEY"


Instead of this, you should just set export AWS_PROFILE=nameofprofile if you're not using the default profile.

Changed and explained the two ways (using the default profile, and when is not being used)

justinsb · 2017-08-15T17:14:52Z

docs/examples/coreos-kops-tests-multimaster.md

+Create a bucket (if you don't already have one) for your cluster state:
+
+```bash
+aws s3api create-bucket --bucket kops-tigerlinux-cluster-state --region us-east-1


This is fine, but probably a good idea to use example and example.com instead of your name in future :-)

justinsb · 2017-08-15T17:15:41Z

docs/examples/coreos-kops-tests-multimaster.md

+Then export the name of your cluster along to the "S3" URL of your bucket:
+
+```bash
+export NAME=coreosbasedkopscluster.k8s.local


You typically don't need to set NAME

If we are consistent with "https://github.com/kubernetes/kops/blob/master/docs/aws.md", we should do it.

justinsb · 2017-08-15T17:18:39Z

docs/examples/coreos-kops-tests-multimaster.md

+    --filters "Name=virtualization-type,Values=hvm" "Name=name,Values=CoreOS-stable*" \
+    --query 'sort_by(Images,&CreationDate)[-1].{id:ImageLocation}' \
+	--output table
+


Given this command doesn't use the AMI we just found here? Or should we remove the previous way of querying? I worry it's confusing to find an AMI using the CoreOS JSON file, but then we don't use it...

I do like your way though!

Include both ways !. You never now when CoreOS page will be available to use the "json".

justinsb · 2017-08-15T17:19:50Z

docs/examples/coreos-kops-tests-multimaster.md

+${NAME}
+```
+
+NOTE: Remember ${NAME} was exported with our cluster name: coreosbasedkopscluster.k8s.local


I think it would be clearer if you set NAME just before you do kops create cluster, because then we differentiate between the things that are one-off and the things that are per-cluster.

Also, can you add a note that by using .k8s.local you're using "gossip dns" and avoiding the need for a route53 domain and a real domain name!

Done. Also I included a mention to the "aws.md" documentation.

justinsb · 2017-08-15T17:20:27Z

docs/examples/coreos-kops-tests-multimaster.md

+kops edit ig --name=${NAME} master-us-east-1c
+```
+
+What you need to change on all your instance groups (masters and nodes) is this:


You can also specify --image=595879546273/CoreOS-stable-1409.8.0-hvm to kops create cluster

You can show how to do it both ways though - when you change an image we don't have a shortcut!

justinsb · 2017-08-15T17:22:51Z

docs/examples/coreos-kops-tests-multimaster.md

+
+## LAUNCH A SIMPLE REPLICATED APP ON THE CLUSTER.
+
+Before doing the tasks ahead, we created a simple "webservers" security group inside our KOPS's cluster VPC (using the AWS WEB-UI) allowing inbound port 80 and applied it to our two nodes (not the masters). Then, with the following command we proceed to create a simple replicated app in our coreos-based kops-launched cluster:


Would be great to add a comment that this is not the recommended way to do things - that we should be using a service of Type=LoadBalancer or an Ingress. But that it is useful to understand how things work :-)

Done, and also included a link to the nginx-ingress MD file.

justinsb · 2017-08-15T17:23:33Z

docs/examples/coreos-kops-tests-multimaster.md

+Deleted cluster: "coreosbasedkopscluster.k8s.local"
+```
+
+NOTE: Before destroying the cluster, "really ensure" any extra security group "not created" directly by KOPS has been removed by you.


Right - maybe say "as otherwise kops will likely be unable to delete the cluster"

Ok !. I'll take all recommendations into account and do the changes to the documentation. All sound OK to me !.

tigerlinux · 2017-08-16T15:59:27Z

Hi there. Required changes/improvements pushed !.

justinsb · 2017-08-17T13:57:12Z

/ok-to-test

/lgtm

Some nits, but I think I'm going to send you back a PR @tigerlinux - seems more efficient with docs :-)

k8s-github-robot · 2017-08-17T13:57:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, tigerlinux

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-17T14:29:22Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-17T15:02:13Z

Automatic merge from submit-queue

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 15, 2017

aledbf reviewed Aug 15, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 15, 2017

justinsb reviewed Aug 15, 2017

View reviewed changes

Changed all CoreOS related documentation

865755e

tigerlinux force-pushed the master branch from 4164c82 to 865755e Compare August 16, 2017 15:55

k8s-ci-robot assigned justinsb Aug 17, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2017

k8s-github-robot merged commit 7274b60 into kubernetes:master Aug 17, 2017

jgmize mentioned this pull request Aug 17, 2017

Eval using CoreOS AMIs with kops mozmeao/infra#438

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes on CoreOS related documentation. #3205

Changes on CoreOS related documentation. #3205

tigerlinux commented Aug 15, 2017

k8s-ci-robot commented Aug 15, 2017

k8s-ci-robot commented Aug 15, 2017

tigerlinux commented Aug 15, 2017

aledbf Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb commented Aug 15, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

justinsb Aug 15, 2017

justinsb Aug 15, 2017

tigerlinux Aug 16, 2017

justinsb Aug 15, 2017

tigerlinux Aug 15, 2017

tigerlinux commented Aug 16, 2017

justinsb commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017


		> Note: SSH username will be `core`
		As part of our documentation, you will find a practical exercise using CoreOS with KOPS. See the file "coreos-kops-tests-multimaster.md" in the "examples" directory. This exercise covers not only using kops with CoreOS, but also a practical view of KOPS with a multi-master kubernetes setup.


		## LAUNCH A SIMPLE REPLICATED APP ON THE CLUSTER.

		Before doing the tasks ahead, we created a simple "webservers" security group inside our KOPS's cluster VPC (using the AWS WEB-UI) allowing inbound port 80 and applied it to our two nodes (not the masters). Then, with the following command we proceed to create a simple replicated app in our coreos-based kops-launched cluster:

Changes on CoreOS related documentation. #3205

Changes on CoreOS related documentation. #3205

Conversation

tigerlinux commented Aug 15, 2017

k8s-ci-robot commented Aug 15, 2017

k8s-ci-robot commented Aug 15, 2017

tigerlinux commented Aug 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinsb commented Aug 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tigerlinux commented Aug 16, 2017

justinsb commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017

k8s-github-robot commented Aug 17, 2017