Read the channel from the local filesystem during tests #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another step towards working totally offline (which may never be fully achievable, because of the need to hash assets). But should ensure that when we update the stable channel, we are testing against that version in the tests, otherwise it is easy to break master.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
approved
|
Not on a mac. Are you saying it doesn't work on a mac? |
This was referenced Aug 24, 2017
|
@chrislovecnm can you please clarify whether this actually failed for you on a mac, or whether you believe it might fail? |
KashifSaadat
approved these changes
Aug 24, 2017
There was a problem hiding this comment.
@chrislovecnm I tested this on OSX, runs and passes cleanly.
LGTM!
Merged
|
/lgtm Thanks @KashifSaadat!!!! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards working totally offline (which may never be fully
achievable, because of the need to hash assets). But should ensure that
when we update the stable channel, we are testing against that version
in the tests, otherwise it is easy to break master.