fix(cert-manager-webhook): fix label name to bypass LBC webhooks

[math3vz]

Similar to #16179

Fixes #16742

It changes label app.kubernetes.io/name from webhook to cert-manager in svc/cert-manager-webhook. This exclude the service from the AWS Load balancer controller mutating webhook configuration as shown in #16179

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: math3vz / name: Matheus Moraes (ab42e7d)

[k8s-ci-robot]

Welcome @math3vz!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @math3vz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[justinsb]

/ok-to-test

[justinsb]

Those failures look unrelated, I think...

/retest

[justinsb]

/retest

[justinsb]

OK so I'm reasonably sure those are unrelated failures ... possibly new tests in 1.31?

[math3vz]

OK so I'm reasonably sure those are unrelated failures ... possibly new tests in 1.31?

I agree, it looks related to the test environment, is there anything I can do?

[justinsb]

We discussed in office hours. We think we understand the failures and they are not regressions, so we're trying to cherry pick to 1.30.0 so we can release that with this included (#16752).

The flurry of WIP PRs are to try to fix the unrelated regressions (and thus verify that they are unrelated).

We think there are two issues:

1. There's a skiplist for some well-known-bad upstream tests that keys off the Kube version: WIP: Try bumping regex skiplist version to include 1.31 #16751
2. There appears to be a bug where if nodeup installs a package that restarts systemd (or some systemd services), that causes nodeup to restart. If we happen to get killed during an apt-get, dpkg can become wedged. That's what WIP: Try running apt-get in background #16750 is investigating, whether we can be more robust to that.

[math3vz]

Hey @hakman @justinsb, I've noticed this got cherry-picked and released at 1.30. Should I make some changes to this pull request?

[hakman]

Thanks for the reminder @math3vz. Let's see! 😄
/lgtm
/approve
/test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[math3vz]

/retest

[math3vz]

@hakman I executed a merge by mistake and lost the approval, can you approve it again?

[k8s-ci-robot]

@math3vz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons	ab42e7d	link	false	/test pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hakman]

@hakman I executed a merge by mistake and lost the approval, can you approve it again?

No worries. Thanks for fixing.
/lgtm