Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cilium): fix several broken links #15325

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs(cilium): fix several broken links #15325

merged 2 commits into from
Jul 3, 2023

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Apr 16, 2023 •
edited
Loading

Summary

Fix some broken links on the Cilium docs page

Details

  • stable route no longer has some of the links, so instead used a specific version of the Cilium docs
    • follows the convention in the rest of this doc to use versions
    • I used the latest version that has the link available

Review Notes

I updated anything with stable but left already versioned ones. The versioned ones still work, but some could be updated to newer versions of the docs. I can do that if wanted, but not sure if y'all would prefer it be an older link closer in time to when the features were added. EDIT: See #15583 which updates the rest of the links that were already versioned

Misc

I had started this and some other docs changes a while ago, finally got to them while making other docs PRs 😅

@agilgur5
docs(cilium): fix several broken links
c869026 
- `stable` route no longer has some of the links, so instead used a
  specific version of the Cilium docs
  - follows the convention in the rest of this doc to use versions
  - I used the latest version that has the link available
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab April 16, 2023 19:10
@k8s-ci-robot
Copy link
Contributor

Hi @agilgur5. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2023
This was referenced Apr 16, 2023
Merged
Merged
hakman
hakman requested changes Apr 19, 2023
View reviewed changes
docs/networking/cilium.md Outdated Show resolved Hide resolved
docs/networking/cilium.md Show resolved Hide resolved
docs/networking/cilium.md Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Apr 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2023
@agilgur5 agilgur5 requested a review from hakman June 23, 2023 22:11
@agilgur5 agilgur5 mentioned this pull request Jul 2, 2023
Merged
@agilgur5
Copy link
Contributor Author

agilgur5 commented Jul 2, 2023

Added #15583 to proactively update the rest (the already versioned links) to v1.13 as well

@hakman
Copy link
Member

hakman commented Jul 3, 2023

Thanks @agilgur5!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79c9649 into kubernetes:master Jul 3, 2023
@agilgur5 agilgur5 deleted the fix-cilium-broken-links branch July 3, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab Awaiting requested review from zetaab

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agilgur5 @k8s-ci-robot @hakman