Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use state store for nodeup.Config in Gossip clusters #14983

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

johngmyers
Copy link
Member

Fixes #14899

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from hakman January 12, 2023 05:20
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 12, 2023
@johngmyers johngmyers changed the title Commits on Jan 11, 2023 Use state store for nodeup.Config in Gossip clusters Use state store for nodeup.Config in Gossip clusters Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2023
@johngmyers johngmyers force-pushed the boot-gossip branch 2 times, most recently from d66bd61 to f06f3c6 Compare January 12, 2023 05:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2023
@johngmyers johngmyers force-pushed the boot-gossip branch 3 times, most recently from 4a9d7d2 to 14bfcc8 Compare January 12, 2023 05:57
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@hakman
Copy link
Member

hakman commented Jan 12, 2023

/test pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot k8s-ci-robot merged commit 8127590 into kubernetes:master Jan 12, 2023
k8s-ci-robot added a commit that referenced this pull request Jan 12, 2023
…-upstream-release-1.26

Automated cherry pick of #14983: Use state store for nodeup.Config in Gossip clusters
@johngmyers johngmyers deleted the boot-gossip branch January 12, 2023 15:02
Shimiazoulai pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jul 13, 2023
…-of-#14983-upstream-release-1.26

Automated cherry pick of kubernetes#14983: Use state store for nodeup.Config in Gossip clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker nodes fail to join cluster due to broken gossip DNS (AWS / 1.26)
3 participants