aws: Use EnsureTask to reference shared target groups #14737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/cc @rifelpet |
|
/test pull-kops-e2e-k8s-ci-ha |
johngmyers
requested changes
Dec 7, 2022
| Lifecycle: b.Lifecycle, | ||
| ARN: extLB.TargetGroupARN, | ||
| Shared: fi.PtrTo(true), | ||
| } | ||
| t.TargetGroups = append(t.TargetGroups, tg) | ||
| c.AddTask(tg) | ||
| c.EnsureTask(tg) |
There was a problem hiding this comment.
Need to check the returned error.
hakman
force-pushed
the
fix_control-plane_tgs
branch
from
2b9b9ab to
0c020cb
Compare
johngmyers
approved these changes
Dec 7, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimises the way we reference shared (external) target groups by using
EnsureTask()instead of pre-pending the autoscaling group name.Ref: #10335