Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Disallow running NTH and Karpenter together #14668

Closed
wants to merge 1 commit into from
Closed

WIP Disallow running NTH and Karpenter together #14668

wants to merge 1 commit into from

Conversation

johngmyers
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johngmyers by writing /assign @johngmyers in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2022
@hakman
Copy link
Member

hakman commented Nov 26, 2022

Are you referring to aws/karpenter-provider-aws#702?

@johngmyers
Copy link
Member Author

I was referring to https://karpenter.sh/v0.19.2/tasks/deprovisioning/#interruption

Seems that's an 0.19 feature and we'd have to turn it on.

@johngmyers johngmyers changed the title Disallow running NTH and Karpenter together WIP Disallow running NTH and Karpenter together Nov 26, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2022
@olemarkus
Copy link
Member

I think it's better to run NTH and Karpenter separately. Especially since we can mix karpenter and ASG-managed modes nodes.

@johngmyers johngmyers closed this Nov 26, 2022
@johngmyers johngmyers deleted the nth-karpenter branch November 29, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @k8s-ci-robot @hakman @olemarkus