Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NAT64 instead of dual-stack for AWS EBS CSI driver #12850

Merged
merged 2 commits into from
Nov 28, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 28, 2021

AWS_EC2_ENDPOINT=https://api.ec2.us-east-1.aws is broken as it overrides both EC2 and STS endpoint (#12843 (comment)).

2021/11/28 02:57:37 DEBUG: Request sts/AssumeRoleWithWebIdentity Details:
---[ REQUEST POST-SIGN ]-----------------------------
POST / HTTP/1.1
Host: api.ec2.us-east-1.aws
User-Agent: aws-sdk-go/1.40.4 (go1.17.3; linux; amd64) exec-env/aws-ebs-csi-driver-v1.5.0
Content-Length: 1291
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Accept-Encoding: gzip

The above is not needed with NAT64 and using AWS_USE_DUALSTACK_ENDPOINT=true needs more testing.

/cc @johngmyers @olemarkus @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/addons labels Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2021
@johngmyers
Copy link
Member

File an issue against kubernetes-sigs/aws-ebs-csi-driver?

@hakman
Copy link
Member Author

hakman commented Nov 28, 2021

File an issue against kubernetes-sigs/aws-ebs-csi-driver?

kubernetes-sigs/aws-ebs-csi-driver#1122

@hakman
Copy link
Member Author

hakman commented Nov 28, 2021

/test pull-kops-e2e-ipv6-calico

@hakman
Copy link
Member Author

hakman commented Nov 28, 2021

The IPv6 test is now passing without any issues:

Ginkgo ran 1 suite in 20m44.576668224s
Test Suite Passed

@k8s-ci-robot k8s-ci-robot merged commit dd4d4e4 into kubernetes:master Nov 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 28, 2021
@hakman hakman deleted the fix_ebs_csi_irsa branch November 28, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants