Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/upload: avoid ACLs for GCS buckets with UBLA enabled #11994

Merged
merged 1 commit into from
Jul 15, 2021
Merged

hack/upload: avoid ACLs for GCS buckets with UBLA enabled #11994

merged 1 commit into from
Jul 15, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 15, 2021

This is intended to fix https://testgrid.k8s.io/kops-presubmits#kops-postsubmit which has been failing since kubernetes/test-infra#22840 merged

It's not clear to me whether this will need to be backported into other release branches or not

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

/cc @hakman @justinsb

@k8s-ci-robot k8s-ci-robot requested review from hakman and justinsb July 15, 2021 05:53
@spiffxp spiffxp mentioned this pull request Jul 15, 2021
Merged
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

/test pull-kops-e2e-kubernetes-aws
not sure if flake

@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

ref: kubernetes/k8s.io#2318

@hakman
Copy link
Member

hakman commented Jul 15, 2021

Thanks @spiffxp. :)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 48497b3 into kubernetes:master Jul 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 15, 2021
@spiffxp spiffxp deleted the no-acls-for-you branch July 15, 2021 15:00
@spiffxp
Copy link
Member Author

spiffxp commented Jul 15, 2021

https://testgrid.k8s.io/kops-presubmits#kops-postsubmit is back to green, thanks!

It's not clear to me whether this will need to be backported into other release branches or not

https://github.com/kubernetes/test-infra/blob/b361f47b351fd428e6cebf06184d092a883a3f40/config/jobs/kubernetes/kops/kops-presubmits.yaml#L463-L465

looks like no

@spiffxp spiffxp mentioned this pull request Jul 15, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@zetaab zetaab Awaiting requested review from zetaab

@hakman hakman Awaiting requested review from hakman

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @hakman @k8s-ci-robot