Automated cherry pick of #11884: support large/slow downloads #11886: Set download timeout to 3 minutes #11891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current download code was using http.client timeout, that will interrupt reading of the response body, breaking slow downloads or very large files. This patch modified the http client to detect idle downloads, and fail after 30 seconds of innactivity. It still keeps a global timeout of 5 minutes.
k8s-ci-robot
added
cncf-cla: yes
|
/cc @johngmyers |
johngmyers
approved these changes
Jun 30, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
deleted the
automated-cherry-pick-of-#11884-#11886-upstream-release-1.21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #11884 #11886 on release-1.21.
#11884: support large/slow downloads
#11886: Set download timeout to 3 minutes
For details on the cherry pick process, see the cherry pick requests page.