bump aws lb controller to 2.2.0 #11502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/addons
area/provider/aws
olemarkus
force-pushed
the
aws-lb-controller-bump
branch
from
43a1c14 to
266918d
Compare
rifelpet
reviewed
May 16, 2021
| "elasticloadbalancing:ModifyTargetGroupAttributes", | ||
| "elasticloadbalancing:ModifyRule", | ||
| "elasticloadbalancing:DeleteRule", | ||
| "elasticloadbalancing:RemoveTags", |
There was a problem hiding this comment.
RemoveTags is being added in both statements. Can we consolidate it to just one statement?
There was a problem hiding this comment.
Hm. Is the last statement redundant? Technically they should be for different types of resources (ELBs vs listeners)
There was a problem hiding this comment.
Think this should work just as well.
olemarkus
force-pushed
the
aws-lb-controller-bump
branch
2 times, most recently
from
fa2c2ce to
8c377cf
Compare
olemarkus
force-pushed
the
aws-lb-controller-bump
branch
from
8c377cf to
7df35fa
Compare
rifelpet
approved these changes
May 16, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
May 18, 2021
…502-origin-release-1.21 Automated cherry pick of #11502: bump aws lb controller to 2.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, we also pass the upstream e2e tests (with some amendments related to them expecting something more similar to EKS).