Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CoreDNS manifests to latest stable version 1.8.3 #11500

Merged
merged 2 commits into from
May 21, 2021
Merged

Bump CoreDNS manifests to latest stable version 1.8.3 #11500

merged 2 commits into from
May 21, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented May 16, 2021

In this commit, we update manifest files of CoreDNS. We also do a small
refactoring on yaml blocks to match the upstream source and to make
updating and reviewing procedures easier on the future.

Signed-off-by: dntosas [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/addons labels May 16, 2021
@dntosas dntosas force-pushed the coredns-bump-manifest branch 2 times, most recently from 6b43e66 to f53cfe1 Compare May 16, 2021 08:22
@dntosas dntosas force-pushed the coredns-bump-manifest branch from f53cfe1 to 9d940da Compare May 16, 2021 08:25
@dntosas dntosas force-pushed the coredns-bump-manifest branch from 9d940da to 740f405 Compare May 16, 2021 08:30
@dntosas dntosas changed the title [addons/coredns] Bump manifests to latest stable version 1.8.3 WIP [addons/coredns] Bump manifests to latest stable version 1.8.3 May 16, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2021
@dntosas
[addons/coredns] Bump manifests to latest stable version 1.8.3
da42bec 
In this commit, we update manifest files of CoreDNS. We also do a small
refactoring on yaml blocks to match the upstream source and to make
updating and reviewing procedures easier on the future.

Signed-off-by: dntosas <[email protected]>
@dntosas dntosas force-pushed the coredns-bump-manifest branch from 740f405 to da42bec Compare May 16, 2021 08:37
@dntosas dntosas changed the title WIP [addons/coredns] Bump manifests to latest stable version 1.8.3 Bump CoreDNS manifests to latest stable version 1.8.3 May 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2021
@dntosas
Copy link
Contributor Author

dntosas commented May 16, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

@dntosas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented May 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2021
@dntosas
Copy link
Contributor Author

dntosas commented May 16, 2021

/retest

1 similar comment
@dntosas
Copy link
Contributor Author

dntosas commented May 16, 2021

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8e938ba into kubernetes:master May 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 21, 2021
@dntosas dntosas mentioned this pull request May 21, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 21, 2021
@k8s-ci-robot
Merge pull request #11547 from dntosas/automated-cherry-pick-of-#1150…
67185a3 
…0-upstream-release-1.21

Automated cherry pick of #11500: Bump patch version
@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@dntosas @k8s-ci-robot @hakman @olemarkus