Set canonical location for downloads to artifacts.k8s.io #11486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Needs rebase. |
k8s-ci-robot
added
the
needs-rebase
hakman
force-pushed
the
canonical_downloads_location
branch
from
4ec16b5 to
ebb1d85
Compare
|
Should be rebased now. Just that ci-robot is a little slow. |
k8s-ci-robot
removed
the
needs-rebase
johngmyers
requested changes
May 13, 2021
docs/release-process.md
Outdated
| ``` | ||
|
|
||
|
|
||
| Binaries to S3 bucket: | ||
| Binaries to S3 bucket (only for kOps < 1.22): |
There was a problem hiding this comment.
Do we do this for Beta releases?
There was a problem hiding this comment.
Not quite related, but updated.
And remove the legacy location for downloads.
hakman
force-pushed
the
canonical_downloads_location
branch
from
ebb1d85 to
a39d829
Compare
johngmyers
approved these changes
May 13, 2021
|
|
||
|
|
||
| Until the binary promoter is automatic, we also need to promote the binary artifacts manually: | ||
| Until the binary promoter is automatic, we also need to promote the binary artifacts manually (only for releases): |
There was a problem hiding this comment.
Suggested change
| Until the binary promoter is automatic, we also need to promote the binary artifacts manually (only for releases): | |
| Until the binary promoter is automatic, we also need to promote the binary artifacts manually (only for stable releases): |
They're all "releases".
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
This was referenced Jun 3, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 3, 2021
…-upstream-release-1.21 Automated cherry pick of #11486: Set canonical location for downloads to artifacts.k8s.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove the legacy location for downloads.
/cc @johngmyers @rifelpet