Apiserver fixes #11293
Merged
Apiserver fixes #11293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API servers also have access to secret store, so there is no need to go through kops-controller. This lets API server only depend on etcd from the CP nodes, which should make it easier to scale out API servers under pressure
k8s-ci-robot
added
cncf-cla: yes
If the cluster is under pressure, especially the new api server nodes, kops-controller go into crash loops because kubernetes.default doesn't respond. By using the local api server, it has a higher likelyhood of being able to connect.
olemarkus
force-pushed
the
apiserver-fixes
branch
from
88585fb to
ab12d18
Compare
k8s-ci-robot
added
size/M
hakman
approved these changes
Apr 23, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two fixes for issues I ran into when stress testing the API. Both are technically around kops-controller going into crashloop, preventing more api servers to join the cluster. See the individual commits for details.