-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to detect field changes when mixedInstancePolicy is removed #11255
Conversation
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This brings up the issue of all those other places where we check a subfield of |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1255-upstream-release-1.19 Automated cherry pick of #11255: Make it possible to detect field changes when
…1255-upstream-release-1.20 Automated cherry pick of #11255: Make it possible to detect field changes when
…pick-of-#11255-upstream-release-1.19 Automated cherry pick of kubernetes#11255: Make it possible to detect field changes when
…pick-of-#11255-upstream-release-1.19 Automated cherry pick of kubernetes#11255: Make it possible to detect field changes when
…pick-of-#11255-upstream-release-1.19 Automated cherry pick of kubernetes#11255: Make it possible to detect field changes when
Refs: #11253
When I remove mixedInstancesPolicy using
kops edit
, there are difference actual and expected. But kops don't detect that changes. So, it was causinginternal consistency error
.I changed
buildChangeList
, so kops can detect field changes when I remove mixedInstancePolicy.