-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kops_create_secret_dockerconfig.md #11186
Conversation
Hi @integrii. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @integrii. Just a small suggestion from me. Please also squash the commits.
/ok-to-test |
/retest Review the full test history for this PR. Silence the bot with an |
Today we were implementing an authenticated docker user, but it was unclear how exactly to do that. We learned that simply making this secret within kops was all that was needed for the docker config to start appearing on newly built nodes. It would be nice if the documentation here reflected that. It would have saved us some time.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/retest |
1 similar comment
/retest |
Today we were implementing an authenticated docker user, but it was unclear how exactly to do that. We learned that simply making this secret within kops was all that was needed for the docker config to start appearing on newly built nodes. It would be nice if the documentation here reflected that. It would have saved us some time.