Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of irsa for aws load balancer controller #11088

Merged
merged 2 commits into from
Apr 4, 2021
Merged

Enable use of irsa for aws load balancer controller #11088

merged 2 commits into from
Apr 4, 2021

Conversation

olemarkus
Copy link
Member

This also improves how we can add irsa data to a manifest.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2021
@olemarkus olemarkus mentioned this pull request Mar 20, 2021
Merged
@olemarkus olemarkus force-pushed the irsa-awslbc branch 2 times, most recently from ce9ce4e to d0e7d9e Compare March 20, 2021 18:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2021
@k8s-ci-robot k8s-ci-robot added area/addons and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 22, 2021
@olemarkus
Copy link
Member Author

/retest

@olemarkus olemarkus requested review from rifelpet and justinsb March 22, 2021 18:37
@olemarkus olemarkus mentioned this pull request Mar 26, 2021
Merged
3 tasks
@olemarkus olemarkus added this to the v1.21 milestone Apr 1, 2021
@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2021

Can we update an integration test case to use this functionality? I'd expect a new iam role for aws-load-balancer-controller being created in the terraform/cloudformation output.

@olemarkus
Copy link
Member Author

Sure. I can PR an integration test for aws load balancer controller that can go in first.

@olemarkus olemarkus mentioned this pull request Apr 4, 2021
Merged
Remarshal new values so we can use the remapper later on
51adb83 
If not, reparse will fail because a path may be e.g a *corev1.Pod
Add irsa support for awslbcontroller
dbd2347 
This commit also introduces support for adding token projection volumes for well-known SAs.
Slightly less complicated than explicitly parsing the objects for a manifest
@olemarkus
Copy link
Member Author

@rifelpet now you can see a policy/role diff here.

@olemarkus
Copy link
Member Author

/retest

@olemarkus
Copy link
Member Author

/test pull-kops-verify-terraform

@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2021

W0404 19:37:06.307277 10744 executor.go:139] error running task "VPC/e2e-6d9ce33ad2-8dfcf.test-cncf-aws.k8s.io" (2m21s remaining to succeed): error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.

:( we can probably rerun each of the e2e tests one at a time. otherwise this LGTM 👍🏻

@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2021

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2021

/test pull-kops-e2e-k8s-containerd

rifelpet
rifelpet approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2021
@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e0835d into kubernetes:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@olemarkus @rifelpet @k8s-ci-robot