Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some nodeup & protokube logging #11052

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Cleanup some nodeup & protokube logging #11052

merged 1 commit into from
Mar 15, 2021

Conversation

rifelpet
Copy link
Member

Removing some noise I see in protokube and nodeup logs. Also log a channels error that we're seeing on flatcar to help with troubleshooting.

https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-distro-imageflatcar/1371259092688965632/artifacts/3.34.196.168/protokube.log

I0315 00:53:47.644156    6154 apply.go:67] Running command: kubectl apply -f /tmp/channel266979825/manifest.yaml
I0315 00:53:47.644171    6154 apply.go:70] error running kubectl apply -f /tmp/channel266979825/manifest.yaml
I0315 00:53:47.644176    6154 apply.go:71]
error updating "limit-range.addons.k8s.io": error applying update from "s3://k8s-kops-prow/e2e-785a7f373f-91d99.test-cncf-aws.k8s.io/addons/limit-range.addons.k8s.io/v1.5.0.yaml": error running kubectl

@rifelpet
Cleanup some nodeup & protokube logging
21389c8 
Also log a channels error that we're seeing on flatcar to help with troubleshooting
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0f743b5 into kubernetes:master Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 15, 2021
@hakman hakman mentioned this pull request Mar 16, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 17, 2021
@k8s-ci-robot
Merge pull request #11058 from hakman/automated-cherry-pick-of-#11052…
15760f4 
…-upstream-release-1.20

Automated cherry pick of #11052: Cleanup some nodeup & protokube logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @k8s-ci-robot @hakman