Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channels entries for image architecture #11046

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 14, 2021

This should fix most requests around having correct images for new clusters and upgrades.

Fixes: #11023

/cc @rifelpet @olemarkus @bharath-123

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/api area/channels labels Mar 14, 2021
@hakman hakman force-pushed the channels-arm64 branch 2 times, most recently from 098e312 to 064df1b Compare March 14, 2021 13:01
channels/stable Outdated Show resolved Hide resolved
@bharath-123
Copy link
Contributor

Tried testing this out with the toolbox command, got this error

bharath12345@Bharaths-MacBook-Pro kops % kops toolbox instance-selector nodes --vcpus 4 --flexible --usage-class spot --cpu-architecture arm64 --cluster-autoscaler --dry-run
Using cluster from kubectl context: test-stuff.kops-cluster.com

I0314 18:48:18.623902   99607 populate_instancegroup_spec.go:260] Cannot set default Image for CloudProvider="aws"

unable to determine default image for InstanceGroup nodes

pkg/apis/kops/channel.go Outdated Show resolved Hide resolved
@rifelpet
Copy link
Member

@bharath-123 your kops build is likely using the upstream master channels file which doesn't have the architecture additions in it. If you update your cluster spec's channel field to the file's URL from this PR then it should work.

https://raw.githubusercontent.com/kubernetes/kops/a5f5f984c99a9cf6b31ab87beee15a5248f50107/channels/stable

@bharath-123
Copy link
Contributor

@bharath-123 your kops build is likely using the upstream master channels file which doesn't have the architecture additions in it. If you update your cluster spec's channel field to the file's URL from this PR then it should work.

https://raw.githubusercontent.com/kubernetes/kops/a5f5f984c99a9cf6b31ab87beee15a5248f50107/channels/stable

Got it @rifelpet Thanks for clearing that out!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9dfbd03 into kubernetes:master Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 15, 2021
k8s-ci-robot added a commit that referenced this pull request Mar 18, 2021
…-upstream-release-1.20

Automated cherry pick of #11046: Add channels entries for image architecture
@hakman hakman deleted the channels-arm64 branch March 22, 2021 08:44
@yurrriq
Copy link
Contributor

yurrriq commented Apr 12, 2021

I'm running into issues using kOps 1.20.0: wrong type for value; expected architectures.Architecture; got string

using this snippets/common/ami:

{{ default (ChannelRecommendedImage $.cloud (include "kubernetesVersion" $) $.architecture) $.image }}

snippets/common/kubernetesVersion:

{{ default ChannelRecommendedKopsKubernetesVersion $.kubernetesVersion }}

with this template

{{ $image := include "ami" $) }}

and these values:

architecture: amd
cloud: aws

Edit: created #11217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/channels area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[toolbox]: instance selector with arm64 arch, outputs wrong arch image
5 participants