Storage: Amend default choice for StorageClass management to honor a specified OpenStack-related value #11002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When choosing a default value for the Cluster spec's "cloudConfig.manageStorageClasses" field, first check whether a user specified a concrete value for the related OpenStack "blockStorage.createStorageClass" field. If so, use that value as the effective default value for the former field as well, so as to avoid an unnecessary conflict between the field values on the second validation pass.
k8s-ci-robot
added
cncf-cla: yes
zetaab
approved these changes
Mar 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
this needs to be backported to release-1.20 also |
See #11003. |
k8s-ci-robot
added a commit
that referenced
this pull request
Mar 9, 2021
…igin-release-1.20 Automated cherry pick of #11002: Honor an OpenStack StorageClass management choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing a default value for the Cluster spec's "cloudConfig.manageStorageClasses" field, first check whether a user specified a concrete value for the related OpenStack "blockStorage.createStorageClass" field. If so, use that value as the effective default value for the former field as well, so as to avoid an unnecessary conflict between the field values on the second validation pass.
See #10733, @zetaab's findings there, and the ensuing discussion in the "kops-dev" channel in the "Kubernetes" Slack workspace for context.
This change is