Exclude CP nodes from load balancers #10945
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
area/provider/openstack
| @@ -84,5 +84,6 @@ func BuildMandatoryControlPlaneLabels() map[string]string { | |||
| nodeLabels[RoleLabelControlPlane20] = "" | |||
| nodeLabels[RoleLabelName15] = RoleMasterLabelValue15 | |||
| nodeLabels["kops.k8s.io/kops-controller-pki"] = "" | |||
| nodeLabels["node.kubernetes.io/exclude-from-external-load-balancers"] = "" | |||
There was a problem hiding this comment.
Should we conditionally add this based on kubernetes minor version?
There was a problem hiding this comment.
If people have enabled the new service logic, they need this label as well. If they haven't, this is no-op. So my preference is to do this unconditionally.
There was a problem hiding this comment.
We have the logic when Masters hosts ingresses, can we somehow disable this behaviour?
Or even do we need to worry about this change?
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The new service node exclusion feature went GA in 1.21. We should mark CP nodes so they don't become targets for LB services.
See kubernetes/kubernetes#97543