Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort external policies when checking for changes #10940

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 27, 2021

Fixes: #10939

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6e7f635 into kubernetes:master Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 27, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 27, 2021
…-upstream-release-1.20

Automated cherry pick of #10940: Sort external policies when checking for changes
k8s-ci-robot added a commit that referenced this pull request Feb 27, 2021
…-upstream-release-1.19

Automated cherry pick of #10940: Sort external policies when checking for changes
@hakman hakman deleted the sort-external-policies branch March 13, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

externalPolicies sort order affects kops update cluster change tracking
3 participants