Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve machine type and image validation #10884

Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 19, 2021

Improving things a bit over #10747.

@hakman
Copy link
Member Author

hakman commented Feb 19, 2021

/cc @rifelpet @bharath-123

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 19, 2021
@hakman hakman removed the request for review from joshbranham February 19, 2021 16:32
@bharath-123
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 19, 2021
…10884-upstream-release-1.20

Automated cherry pick of #10747: Add validation for ami arch to instance type arch #10884: Improve machine type and image validation
@hakman
Copy link
Member Author

hakman commented Feb 19, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6123c85 into kubernetes:master Feb 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 19, 2021
@hakman hakman deleted the fix-validate-instance-type-and-image branch February 23, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants