Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubetest2 - add ginkgo node debug logs #10866

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

rifelpet
Copy link
Member

from ginkgo --help:

  -debug
    	If set, ginkgo will emit node output to files when running in parallel.

This updates kubetest2 dependency to include kubernetes-sigs/kubetest2#92

If this works on the presubmit job i'll include it in all the periodics as well.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2021
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet rifelpet force-pushed the kubetest2-ginkgo-logs branch from ce3b608 to 8a5e95b Compare February 18, 2021 01:14
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member Author

This is good to merge 👍🏻 the ginkgo-node-*.log files are now present in the job artifacts

@hakman
Copy link
Member

hakman commented Feb 18, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit d52e96f into kubernetes:master Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 18, 2021
@rifelpet rifelpet deleted the kubetest2-ginkgo-logs branch May 5, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants