Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenStack delete functions #10849

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Fix OpenStack delete functions #10849

merged 1 commit into from
Feb 17, 2021

Conversation

ottosulin
Copy link
Contributor

@ottosulin ottosulin commented Feb 16, 2021 •
edited
Loading

This PR fixes #10724 with these two changes:

  1. Add missing RetryWithBackoff to DeleteInstanceWithID
  2. Fix broken retry logic in all other delete functions. In the current implementation, as the first Delete request will almost certainly return nil, the function will return true and the retry will not try again, resulting in potentially some assets not getting deleted from OpenStack

Also, the current writeBackoff is a bit too aggressive and I introduced less hasty deleteBackoff.

The change has been tested with OpenStack. I verified that all APIs we are hitting will eventually return the 404 (type) we are looking for.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ottosulin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2021
@zetaab
Copy link
Member

zetaab commented Feb 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2021
@zetaab
Copy link
Member

zetaab commented Feb 16, 2021 •
edited
Loading

please remove k8s.io folder from the pr

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2021
zetaab
zetaab requested changes Feb 17, 2021
View reviewed changes
upup/pkg/fi/cloudup/openstack/router.go Outdated Show resolved Hide resolved
@ottosulin
Fix OpenStack delete functions
24dcd84 
This PR introduces two fixes:
1) Add missing RetryWithBackoff to DeleteInstanceWithID
2) Fix broken retry logic in all other delete functions. In the current implementation, as the first Delete request will almost certainly return nil, the function will return true and the retry will not try again, resulting in assets not getting deleted from OpenStack

Also, the current writeBackoff is pretty aggressive and I introduced a bit less hasty deleteBackoff.

The change has been tested with OpenStack. I verified that all APIs we are hitting will eventually return the 404 (type) we are looking for.
zetaab
zetaab approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ottosulin, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit dbd503f into kubernetes:master Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 17, 2021
@zetaab zetaab removed this from the v1.20 milestone Feb 17, 2021
@zetaab zetaab mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@hakman hakman Awaiting requested review from hakman

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OpenStack] Ensure that instances are really deleted
3 participants
@ottosulin @k8s-ci-robot @zetaab