Precreate the kops-controller DNS name #10833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing test failures in prow because nodes are not able to resolve the kops-controller dns record. Judging by timestamps, dns-controller adds the record after it is first queried by nodeup. The negative TTL is long enough that the cluster doesn't validate within the alotted time. Rather than increasing the validation timeout I think its better to precreate the DNS record the same way we do for the other records.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This may be a good backport. |
k8s-ci-robot
added
the
lgtm
This was referenced Feb 16, 2021
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 16, 2021
…33-origin-release-1.20 Automated cherry pick of #10833: Precreate the kops-controller DNS name
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 16, 2021
…33-origin-release-1.19 Automated cherry pick of #10833: Precreate the kops-controller DNS name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing test failures in prow because nodes are not able to resolve the kops-controller dns record.
Judging by timestamps, dns-controller adds the record after it is first queried by nodeup.
The negative TTL is long enough that the cluster doesn't validate within the alotted time.
Rather than increasing the validation timeout I think its better to precreate the DNS record the same way we do for the other records.
example job, nodeup logs, and dns-controller logs