kubetest2 - Dump all pod logs in addition to host logs #10799
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
| @@ -46,6 +46,10 @@ func (d *deployer) DumpClusterLogs() error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := d.dumpClusterInfo(); err != nil { | |||
| return err | |||
There was a problem hiding this comment.
A thought ... we may want to do these as best-effort (e.g. trying each dump step and returning a list of errors at the end)
|
Thanks @rifelpet ... assuming this passes lgtm! What look like infra flakes, so: /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! rather than waiting for kubetest2 to support a --timeout flag I'm thinking we could add one ourselves in our tester that would interrupt our Execute() call to kubetest2's ginkgo execution. Perhaps we could also issue an ABRT to the ginkgo process to get its stack traces. |
|
/test pull-kops-e2e-kubernetes-aws |
kubectl cluster-info dumpwill dump all etcd data into the provided directory organized by namespace. I'm hoping this will assist with troubleshooting our timeout issues once we add timeout support to kubetest2 so that we can invoke this shutdown process after the tests timeout.