nodeup file: Set owner & group when we write the file. #10757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/nodeup
approved
Otherwise we had an issue where the file existed with the correct owner/group; when we rewrote it we set the owner/group to root/root; but we then didn't set the owner/group if they were previously correct. Was visible in the flatcar test results.
justinsb
force-pushed
the
nodeup_set_owner_group
branch
from
6494073 to
4ca4541
Compare
k8s-ci-robot
added
size/M
hakman
force-pushed
the
nodeup_set_owner_group
branch
from
f781d8b to
47adc91
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 8, 2021
…-upstream-release-1.19 Automated cherry pick of #10757: nodeup file: Set owner & group when we write the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we had an issue where the file existed with the correct
owner/group; when we rewrote it we set the owner/group to root/root;
but we then didn't set the owner/group if they were previously
correct.
Was visible in the flatcar test results.