Add overrides testing in lifecycle integration tests #10752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This allows specific changes to be tested during an `update cluster --yes` and ensuring a subsequent `update cluster` dryrun correctly reports no changes. To specify changes, create a cluster.overrides.txt or instancegroup.<name>.overrides.txt file in the update_cluster integration test's directory. Each line is a field=value format, each batch of changes is separated by a `---` line. Each batch will be ran through `update cluster --yes`
rifelpet
force-pushed
the
lifecycle-integration-test
branch
from
f153d2d to
dd1ebb8
Compare
|
/test pull-kops-e2e-k8s-containerd |
|
/test pull-kops-e2e-kubernetes-aws |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specific changes to be tested on an existing cluster during an
update cluster --yesand ensuring a subsequentupdate clusterdryrun correctly reports no changes.To specify changes, create a
cluster.overrides.txtorinstancegroup.<name>.overrides.txtfile in the update_cluster integration test's directory as demonstrated here.Each line is a field=value format, each batch of changes is separated by a
---line.Each batch will be ran through
update cluster --yeson its own.In particular, reverting #10742 correctly caused a panic, so these tests are now capable of exposing those types of bugs.