Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about informal office hours #10650

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Add a note about informal office hours #10650

merged 1 commit into from
Mar 4, 2021

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2021
@olemarkus
Copy link
Member Author

Too bad we cannot add a EU timezone to the list. Cursed DST.

@hakman
Copy link
Member

hakman commented Jan 24, 2021

Too bad we cannot add a EU timezone to the list. Cursed DST.

Too bad EU politics is not open source too 😁.

@rifelpet
Copy link
Member

if we do make this timeslot official and reoccurring we should also add it here:

https://github.com/kubernetes/community/blob/f34992d3579d3923ffa6ae8597f2515d632960c3/sigs.yaml#L1056-L1066

@rifelpet
Copy link
Member

rifelpet commented Mar 4, 2021

This was much harder to find than it should be but I managed to find a public calendar for SCL that includes the kops meetings:

https://calendar.google.com/calendar/embed?src=u5822lrl4q68ic1iakuvcpe7b4%40group.calendar.google.com&ctz=America%2FChicago

We could link to that rather than using the even/odd week terminology.

@hakman
Copy link
Member

hakman commented Mar 4, 2021

That link is great! Without the ctz thing it even converts to my local one:
https://calendar.google.com/calendar/u/0/[email protected]

@olemarkus
Copy link
Member Author

Cool. I'll update the PR with this link.

How should I now distinguish the two office hours? Regular is always recorded and tends to focus on decisions, while "bonus hours" is only recorded when needed and is more informal discussions?

@hakman
Copy link
Member

hakman commented Mar 4, 2021

Sounds good.

@olemarkus olemarkus force-pushed the docs-office-hours branch from a4751d4 to 61d19a4 Compare March 4, 2021 08:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2021
@olemarkus olemarkus force-pushed the docs-office-hours branch from 61d19a4 to e6edad4 Compare March 4, 2021 08:46
hakman
hakman requested changes Mar 4, 2021
View reviewed changes
docs/welcome/office_hours.md Outdated Show resolved Hide resolved
docs/welcome/office_hours.md Outdated Show resolved Hide resolved
docs/welcome/office_hours.md Outdated Show resolved Hide resolved
@hakman
Add a note about informal office hours
cbffdf3 
Update docs/welcome/office_hours.md

Co-authored-by: Ciprian Hacman <[email protected]>

Apply suggestions from code review

Co-authored-by: Ciprian Hacman <[email protected]>
@olemarkus olemarkus force-pushed the docs-office-hours branch from 1fa2165 to cbffdf3 Compare March 4, 2021 09:04
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-verify-gomod

gomod?

@hakman
Copy link
Member

hakman commented Mar 4, 2021

Maybe rebase is needed...

@olemarkus
Copy link
Member Author

This is fully rebased ...

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 83e062a into kubernetes:master Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@olemarkus @hakman @rifelpet @k8s-ci-robot @fejta-bot