-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containerd option for registry mirrors #10507
Add containerd option for registry mirrors #10507
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
865a48b
to
66039f1
Compare
/hold for more comments if necessary |
looks good. I ll rework my PR to default systemd as a cgroup-driver to use this toml library. Thanks for doing this! |
can you use the field in an integration test so we can confirm the expected output? |
Sounds good to me. Done. |
Seems like it's ready now. Thanks everyone :). |
/lgtm |
Thanks @olemarkus |
Manual cherry-pick of #10507: Add containerd option for registry mirrors
This simplifies the way containerd options can be added, using
pelletier/go-toml
.Next step for 1.20 would be to move config generation to NodeUp.
/cc @olemarkus @zetaab
@bharath-123