Remove support for Kubenet with containerd #10501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/nodeup
approved
hakman
force-pushed
the
remove-kubenet-containerd
branch
from
dafcf1a to
4c8ae0b
Compare
k8s-ci-robot
added
size/L
hakman
force-pushed
the
remove-kubenet-containerd
branch
from
4c8ae0b to
9f7a2e7
Compare
olemarkus
reviewed
Dec 27, 2020
hakman
force-pushed
the
remove-kubenet-containerd
branch
4 times, most recently
from
f92d0ea to
2460bd9
Compare
hakman
force-pushed
the
remove-kubenet-containerd
branch
from
2460bd9 to
c02e5a2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 28, 2020
…-upstream-release-1.19 Automated cherry pick of #10501: Remove support for Kubenet with containerd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubenet is not actually supported for containerd and is unmaintained in general. Our current Kubenet setup for containerd is actually a "hack" that should be used only for development.
I had a longer discussion with some people involved in SIG-Networking and the recommendation is to remove this hack and also to stop using Kubenet in general (especially not as a default).