Kubectl context message #1050
Merged
Kubectl context message #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
fixing kubectl config path when set to multiple paths
chrislovecnm
force-pushed
the
kubectl-context-message
branch
from
4cedd15 to
bad489c
Compare
|
Good to go 😀 |
|
Jenkins Kubernetes AWS e2e failed for commit bad489c. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot aws e2e test this |
krisnova
reviewed
Dec 7, 2016
| @@ -183,20 +184,31 @@ func (c *KubeconfigBuilder) WriteKubecfg() error { | |||
| return err | |||
| } | |||
| } | |||
| fmt.Printf("Wrote config for %s to %q\n", c.Context, c.KubeconfigPath) | |||
There was a problem hiding this comment.
Fine for now - but you know how I feel about fmt.Print*
There was a problem hiding this comment.
I don't think I do @kris-nova ... Is this because we should be writing to a stream somewhere?
|
LGTM - simple change, and some much needed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #397, #1000
Please review and merge.
This change is