Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for setting the volume encryption key in AWS #10359

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Add option for setting the volume encryption key in AWS #10359

merged 3 commits into from
Dec 8, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 3, 2020

Fixes: #9728

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider labels Dec 3, 2020
@hakman hakman force-pushed the vol-encrypt-key branch 4 times, most recently from 5106da1 to c3701b5 Compare December 3, 2020 09:41
@hakman hakman force-pushed the vol-encrypt-key branch 3 times, most recently from 1619112 to 8f8e314 Compare December 8, 2020 04:39
@rifelpet
Copy link
Member

rifelpet commented Dec 8, 2020

could you add the new key field to the complex integration test's IG volumes?

@rifelpet
Copy link
Member

rifelpet commented Dec 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5e769bc into kubernetes:master Dec 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 8, 2020
@hakman hakman deleted the vol-encrypt-key branch December 8, 2020 05:53
@hakman hakman mentioned this pull request Dec 8, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 8, 2020
@k8s-ci-robot
Merge pull request #10383 from hakman/automated-cherry-pick-of-#10359…
deecef2 
…-upstream-release-1.19

Automated cherry pick of #10359: Add option for setting the volume encryption key in AWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@mikesplain mikesplain mikesplain left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Allow root volume encryption (on AWS)
4 participants
@hakman @k8s-ci-robot @rifelpet @mikesplain